Possibly, but not if they believe Gaudreau has his heart set on becoming a UFA and signing in Philly regardless. Could teams beat that offer if Johnny is willing to commit to them long-term? I agree with you, yes.
From a Flyers perspective--JVR, Patrick and a 1st for Gaudreau and Bennett is a very good deal. Johnny gives the Flyers a dynamic, flashy forward and a good "hometown" story to market. Bennett and Patrick could both benefit from a new start IMO. Bennett due to his role and Patrick due to injuries and the pressure that comes with being drafted 2nd overall.
From a Flames perspective--they get a decent scorer in JVR who is actually a bit better than his stat line last year. They also get Patrick--who, if he can stay healthy, could tilt this deal in the Flames favor quite a bit. A 1st round pick is extremely valuable. I think the Flyers would even be willing to add a future 2nd round pick to the deal to make it happen, considering Gaudreau will likely be in their long-term plans.
I think this is a fair trade for a player who wants to play in Philly... and where there is presumed mutual interest.