Eh, I dunno if the ROR contract is that bad. O'Reilly will be 25 when it starts and ends at 32, and a 25 year old Ryan O'Reilly would have gotten 7M pretty easily if he had made it to free agency.
I think it's a bad contract, but I don't think that's so much on the Sabres as it the current perception of players like Ryan O'Reilly.
We've seen a trend where forwards who are perceived to be elite defensively are making star money even if their offense isn't clearly first line calibre. ROR is a 15-40 guy most years. Maybe a reasonable 1B, and Buffalo will need to hand out big raises during the life of that deal to more important pieces.