The narrative around Schenn is just ridiculous at this point. Schenn was a good player here, he's a good player in St. Louis. He'll be a good player for another 5 years. He's scoring a ppg on one of the worst offensive teams in the league.
The trade can definitely work out for the Flyers but we're a long way from reaping any benefits from it.
It's a trade that's neither great nor terrible. They got 2 1sts and those guys may or may not turn out. He's a very good player who was sort of an odd-man out here, despite two straight 25g/55p seasons. He was traded before the Giroux move to wing, but after Hextall knew that either Hischier or Patrick was going to be a Flyer, which left him...Giroux, Couturier, and one of those 2, with Konecny, Simmonds, Voracek, and a handful of draft picks (Lindblom included) looking to round out top 6/9 wings.
The calculation was, for what he'd eventually cost, he might not have an appropriate role. The value was alright for him, and there's no way of seeing the future...only guessing to the best of your abilities. I simultaneously wish he was still around and am completely fine that he isn't.