Let's face it, there are players in the NHL, born in Canada, with modified no-trade lists that include all 7 Canadian teams.
The tax rate doesn't help, at all.
Winnipeg and Edmonton are known for cold and dark winters. Vancouver is nice but expensive and get a lot of rain I'm told. Montreal will always have the language issue rightly or wrongly.
But Calgary is a beautiful city, I lived there briefly (had to leave to take a job offer elsewhere) but I could of stayed there and loved it. As a player it would be right up there for me. Too bad they are mismanaged and have refused to do a full rebuild.
Ottawa I found to be very nice, I lived an hour south for almost 2 years many moons ago. But putting that rink all the way out in Kanata was a huge, huge blunder, I cannot stress that enough.