With the way demographics are changing, the cost of playing entry-level hockey, etc, basketball may be more popular. Now, Hockey still owns the desirable demographic of wealthy males 19-49. But, even that is shifting as kids who grew up primarily basketball fans enter the workforce and grow into senior management positions. A ton of my friends from university who are 2nd generation Canadians, who are somewhat indifferent to hockey, but love Basketball or Soccer are now entering a phase of there lives where they are making good 6 figure salaries and fit in one of the most desired areas for advertisers.
I love hockey, grew up playing it, have followed the Leafs for as long as I can remember. But, it is just not a very inclusive or accessible sport. That was 20 years ago, and even since then costs have risen significantly. It's easy to buy a ball and play at a local park. Hockey to play consistently is a significant investment time (driving from rink to rink mid-week for travel hockey) and money-wise.