Solid job? Not really. He's done a mediocre job actually and if wasn't for the luck of winning the draft lottery TWICE, he'd probably be out of work.
He used a fluke inherited draft lottery winner in Adam Larsson (Devils were a 100 point team the season before and Cup Finals team the season after that draft) to trade for Taylor Hall, won the 2017 draft lottery to select Nico Hischier with just an 8.5% chance and then just won the 2019 draft lottery with just and 11.5% chance to select Jack Hughes.
They could have very well dropped down in both drafts and it would have been a different story and Devils fans wouldn't be as positive as they are right now. That's cutting it real close.
He's been really lucky and speaking of luck, if not for a gifted 5-on-3 in Game 3 against Tampa Bay in the 2018 playoffs, they would have been swept.
Shero is going into his fifth season as NJ's GM, has missed the playoffs 3 out of 4 seasons and it's time to stop blaming the previous GM and scouting staff. He's now had the luxury of benefiting from THREE draft lottery winning players either directly or indirectly. Most teams or franchises don't see that in their entire history, let alone 1 GM has them at their disposal within a 4-year period. There's really no more excuses to not put together a somewhat decent team.
He's really not done a good job, save for a couple of good trades. Other than that, there's no way he can get credit for draft lottery wins. Seems like the after glow of this weekend is making people forget about the mediocrity of Ray Shero.