You're also basing this off of hardware that came out in 2013 with downgraded graphics to specifically meet the needs for the One S. The One S has not aged well at all, mainly because even when the original One came out, it was still underpowered compared to the original PS4. Also, if I remember correctly, when the Xbox One originally came out, they were losing money for each console sold for the first year or two before starting to break even.
The One S isn’t bad at all. I bought a One X for RDR2 and kinda regret it because I don’t see much difference. Most games don’t even take advantage of the extra hardware. I think for $250 the One S would be better than a PC in that price range. Most people game to have fun and play with their friends which is way more convenient on a console. It’s easier to move around and you can share games with a family member or friend. I don’t know one friend who has a gaming PC and if you prefer playing with a controller you’re going to be at a automatic disadvantage in competitive FPS.
I have a relatively high end PC (although my GPU is aging now) and I appreciate how it can make certain games look. GTA, Skyrim, Witcher 3 all have noticeably better graphics. The older I get though the more I want to lay on my couch and relax after work. I rarely use my PC for gaming because of that.
I guess it depends on what’s important to you and if your friends game on PC. For the average gamer a console makes way more sense. The graphic differences aren’t as major as people make them and you need to spend a fair amount to make them noticeable to the average person. I think the PS4 is the best bet with exclusives like Spiderman, God of War, The Last of Us. Could probably get it under $250.